Change in vdsm[master]: response: insert results into 'info'

fromani at redhat.com fromani at redhat.com
Wed Jul 8 13:43:02 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: response: insert results into 'info'
......................................................................


Patch Set 1:

let's consider VM.migrationCreate.
Doesn't the schema (and thus Engine :)) require a response value like

  {
    'status': {
      'code': 0,
      'message': 'success',
    }
    'migrationPort': 0,
    'params': ... # VM params
  }

?

with this patch, this will become

  {
    'status': {
      'code': 0,
      'message': 'success',
    }
    'info': {
      'migrationPort': 0,
      'params': ... # VM params
    }
  }

and Engine we'll break backward compatibility. Isn't it?

-- 
To view, visit https://gerrit.ovirt.org/43236
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5284969585e55a230be31bde56956fc966e46c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list