Change in vdsm[master]: iscsicred: Install the iscsi-cred directory

nsoffer at redhat.com nsoffer at redhat.com
Wed Jul 8 11:18:37 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: iscsicred: Install the iscsi-cred directory
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/43257/2/vdsm.spec.in
File vdsm.spec.in:

Line 804: %ghost %dir %attr(-, %{vdsm_user}, %{vdsm_group}) @vdsmrepo@/mnt
Line 805: %dir %{_libexecdir}/%{vdsm_name}
Line 806: %dir %{_sysconfdir}/%{vdsm_name}
Line 807: %dir %{_sysconfdir}/%{vdsm_name}/mom.d
Line 808: %dir %{_sysconfdir}/%{vdsm_name}/iscsi-cred
Dan, this directory is world readable now - do you think we need it should be owned by vdsm and readable only by vdsm?
Line 809: %dir %{_datadir}/%{vdsm_name}
Line 810: %dir %{_datadir}/%{vdsm_name}/network
Line 811: %dir %{_datadir}/%{vdsm_name}/network/configurators
Line 812: %dir %{_datadir}/%{vdsm_name}/network/tc


-- 
To view, visit https://gerrit.ovirt.org/43257
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea9359291a4bea9fa0d93d52f44f1e0af5235a4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list