Change in vdsm[master]: vm: extract subset of running vm stats
fromani at redhat.com
fromani at redhat.com
Wed Jul 8 09:44:13 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vm: extract subset of running vm stats
......................................................................
Patch Set 1:
(3 comments)
https://gerrit.ovirt.org/#/c/43285/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1360: if 'boot' in self.conf:
Line 1361: stats['boot'] = self.conf['boot']
Line 1362: return stats
Line 1363:
Line 1364: def _getUpVmStats(self):
A docstring is needed. We need to highlight what "UpVmStats", "DownVmStats" and "RunningVmStats" are.
Line 1365: stats = {
Line 1366: 'elapsedTime': str(int(time.time() - self._startTime)),
Line 1367: 'monitorResponse': str(self._monitorResponse),
Line 1368: 'timeOffset': self.conf.get('timeOffset', '0'),
Line 1413: utils.convertToStr(decStats[var][value])
Line 1414: except Exception:
Line 1415: self.log.exception("Error setting vm disk stats")
Line 1416:
Line 1417: stats.update(self._getGraphicsStats())
maybe add these as well?
Line 1418: stats['hash'] = str(hash((self._domain.devices_hash,
Line 1419: self.guestAgent.diskMappingHash)))
Line 1420: if self._watchdogEvent:
Line 1421: stats['watchdogEvent'] = self._watchdogEvent
Line 1417: stats.update(self._getGraphicsStats())
Line 1418: stats['hash'] = str(hash((self._domain.devices_hash,
Line 1419: self.guestAgent.diskMappingHash)))
Line 1420: if self._watchdogEvent:
Line 1421: stats['watchdogEvent'] = self._watchdogEvent
and this?
Line 1422: if self._numaInfo:
Line 1423: stats['vNodeRuntimeInfo'] = self._numaInfo
Line 1424: if self._vcpuLimit:
Line 1425: stats['vcpuUserLimit'] = self._vcpuLimit
--
To view, visit https://gerrit.ovirt.org/43285
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3e2c19d0b69e78f463976478ded12f306e2f2c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list