Change in vdsm[master]: freeze: Freeze guest even when creating memory snapshot

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Jul 8 06:11:33 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: freeze: Freeze guest even when creating memory snapshot
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/43299/3//COMMIT_MSG
Commit Message:

Line 10: probably done because qemu is pausing the vm for creating memory
Line 11: snapshot.
Line 12: 
Line 13: However, this is not consistent with snapshots of external disks such as
Line 14: network disks, where we always freeze the vm before taking the snapshot.
why does it need to be consistent? AFAIK we freeze non-memory snapshots for only one reason - that the disks are in consistent state. When memory snapshots ensures that why should we freeze?
Line 15: Also, it is probably safer to freeze even when creating memory snapshot,
Line 16: giving applications on the guest chance to pause in consistent state.
Line 17: 
Line 18: This patch removes the check for memory snapshot, and freeze the guest


Line 12: 
Line 13: However, this is not consistent with snapshots of external disks such as
Line 14: network disks, where we always freeze the vm before taking the snapshot.
Line 15: Also, it is probably safer to freeze even when creating memory snapshot,
Line 16: giving applications on the guest chance to pause in consistent state.
AFAICT from libvirt code, it's unneeded.
Line 17: 
Line 18: This patch removes the check for memory snapshot, and freeze the guest
Line 19: unless it is already frozen.
Line 20: 


-- 
To view, visit https://gerrit.ovirt.org/43299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8aa7ac0dea8690ca33df8067f84734d788da8bf8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list