Change in vdsm[master]: lib: migration: add response.is_failure helper

nsoffer at redhat.com nsoffer at redhat.com
Tue Jul 7 21:33:26 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lib: migration: add response.is_failure helper
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42795/7/lib/vdsm/response.py
File lib/vdsm/response.py:

Line 49:         }
Line 50:     }
Line 51: 
Line 52: def is_failure(res):
Line 53:     return res["status"]["code"] != doneCode["code"]
Why we don't need now the MalformedResponse class? and why is_failure is better then is_error?

We have success() and error() - is_error() is a very good name to detect an error response. is_failure() is rather confusing - is this an error response, or something different?

Bad rebase?


-- 
To view, visit https://gerrit.ovirt.org/42795
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccefec4f1bebcb2ca64f0bc9f6b9e9954dbf04c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list