Change in vdsm[master]: net: SetupNetworks small cleanups

phoracek at redhat.com phoracek at redhat.com
Tue Jul 7 15:10:49 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: SetupNetworks small cleanups
......................................................................


Patch Set 27: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/42022/27/vdsm/network/api.py
File vdsm/network/api.py:

Line 715: 
Line 716: def _update_add_network_arguments(attrs, bondings, _netinfo):
Line 717:     """update a specific network attributes with relevant bonding/nic
Line 718:     info."""
Line 719:     args = dict(attrs)
i know it was this way in original file, but this dict(attrs) returns a deepcopy of attrs (which is already a dict) right? imho it would make more sense to explicitly deepcopy it
Line 720:     if 'bonding' in args:
Line 721:         args.update(_build_bond_options(
Line 722:             args['bonding'], bondings, _netinfo))
Line 723:     else:


-- 
To view, visit https://gerrit.ovirt.org/42022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list