Change in vdsm[master]: v2v: Add factory method for ImportVm class

fromani at redhat.com fromani at redhat.com
Tue Jul 7 11:38:32 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: Add factory method for ImportVm class
......................................................................


Patch Set 3: Code-Review+1

I like it. In the calling sites it makes the code a bit nicer. The implementations looks OK too.

-- 
To view, visit https://gerrit.ovirt.org/42065
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5689bc80d66499e1884344d80df127b513507ab7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list