Change in vdsm[master]: vdscli: jsonrpc: add a creation method for client
ykaplan at redhat.com
ykaplan at redhat.com
Tue Jul 7 09:06:14 UTC 2015
Yeela Kaplan has posted comments on this change.
Change subject: vdscli: jsonrpc: add a creation method for client
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/43092/4/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:
Line 106: def connect(requestQueue, stompClient=None,
Line 107: host=None, port=None,
Line 108: useSSL=None,
Line 109: responseQueue=None):
Line 110: if not stompClient:
> Why do we want to use standalone client to build StompRpcClient or build it
because in the case of migration we'd like to use the vdsm reactor and not use a separate one...
and then we supply our own client.
Line 111: client = _create(requestQueue,
Line 112: host, port, useSSL,
Line 113: responseQueue)
Line 114: else:
--
To view, visit https://gerrit.ovirt.org/43092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia99533227b0c3241d7951a2f39af2ff3a6210b5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list