Change in vdsm[master]: xmlrpc: use deque for incoming requests

danken at redhat.com danken at redhat.com
Mon Jul 6 19:56:02 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: xmlrpc: use deque for incoming requests
......................................................................


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/42915/8//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: xmlrpc: use deque for incoming requests
Line 8: 
Line 9: This patch changes how we manage queued requests when stopping the server. When
Line 10: we stop we drop all other requests and add sentinel to stop the server.
could you provide here the motivation for this change?

Do we suspect that we had blocked forever due to a full queue?
Line 11: 
Line 12: 
Line 13: Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a


-- 
To view, visit https://gerrit.ovirt.org/42915
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list