Change in vdsm[master]: net: ignore bondingOptions in persistent networks.
danken at redhat.com
danken at redhat.com
Mon Jul 6 16:36:43 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: net: ignore bondingOptions in persistent networks.
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43233/3/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 365: normalized_opts = self._parse_bond_options(
Line 366: bond_attr.get('options'))
Line 367: bond_attr['options'] = self._netinfo.bondOptsForIfcfg(
Line 368: normalized_opts)
Line 369: # before d18e2f10 bondingOptions were also part of networks, so in case
Please use the
# REQUIRED_FOR upgrade from vdsm<=4.16.20
so it is easier to drop in the future.
Line 370: # we are upgrading from an older version, they should be ignored if
Line 371: # they exist.
Line 372: for net_attr in config_copy.networks.itervalues():
Line 373: net_attr.pop('bondingOptions', None)
--
To view, visit https://gerrit.ovirt.org/43233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c29d4e6c109d4fa7b2d293133b8551e423ec139
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list