Change in vdsm[master]: netinfo, tool: make bonding defaults a proper Python module

danken at redhat.com danken at redhat.com
Mon Jul 6 16:07:36 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo, tool: make bonding defaults a proper Python module
......................................................................


Patch Set 12: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/33890/12/lib/vdsm/tool/dump_bonding_defaults.py
File lib/vdsm/tool/dump_bonding_defaults.py:

Line 59: 
Line 60: 
Line 61: def _output_path():
Line 62:     """Return the full path to bonding_defaults (in the path of lib/netinfo)"""
Line 63:     return join(abspath(dirname(netinfo_path)), 'bonding_defaults.py')
vdsm must not write stuff under /usr/lib. This highly impolite, and the destination may be mounted read-only.
Line 64: 
Line 65: 
Line 66: @expose('dump-bonding-defaults')
Line 67: def main(*args):


-- 
To view, visit https://gerrit.ovirt.org/33890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1f62c0052e42ea23cc06e64fc9e158bf5dc4258
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list