Change in vdsm[master]: tests: functional - convert to run over jsonrpc
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Jul 6 14:23:00 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: tests: functional - convert to run over jsonrpc
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/43237/3/tests/functional/utils.py
File tests/functional/utils.py:
Line 71: def __init__(self):
Line 72: retry(self.start, (socket.error, KeyError), tries=30)
Line 73:
Line 74: def start(self):
Line 75: if config.getboolean('vars', 'jsonrpc_enable'):
What do you think about making it configurable with jsonrpc being default?
I think there is no point in test to check config whether it is enabled.
Line 76: requestQueues = config.get('addresses', 'request_queues')
Line 77: requestQueue = requestQueues.split(",")[0]
Line 78: self.vdscli = jsonrpcvdscli.connect(requestQueue)
Line 79: else:
--
To view, visit https://gerrit.ovirt.org/43237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I468e7eae74dd37b915b15e18ac4b0a830675cb47
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list