Change in vdsm[master]: xmlrpc: do not block forever when waiting on incoming messages

nsoffer at redhat.com nsoffer at redhat.com
Mon Jul 6 11:05:44 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: xmlrpc: do not block forever when waiting on incoming messages
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/42915/7//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-07-03 12:59:15 +0200
Line 4: Commit:     Piotr Kliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-07-06 06:31:21 -0400
Line 6: 
Line 7: xmlrpc: do not block forever when waiting on incoming messages
> We check the flag but according to the core dump we get stuck here and we w
Waiting for join() does not prove anything. Do you see the server thread blocked on queue.get() in the same time?
Line 8: 
Line 9: Vdsm build using jenkins got stuck several times and after coredump
Line 10: analysis it was clear that we hang on self._thread.join().
Line 11: 


-- 
To view, visit https://gerrit.ovirt.org/42915
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I295e3099ea06d786741164e1f240f4662631bf8a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list