Change in vdsm[master]: resize-lun: Fix resizing when vg has multiple pvs

frolland at redhat.com frolland at redhat.com
Mon Jul 6 10:40:18 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: resize-lun: Fix resizing when vg has multiple pvs
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/42608/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-06-21 14:43:08 +0300
Line 4: Commit:     Fred Rolland <frolland at redhat.com>
Line 5: CommitDate: 2015-06-21 16:00:43 +0300
Line 6: 
Line 7: resize-lun: resizePV parameters
> Also fix the title, look to me like "Fix resizing when vg has multiple pvs"
Done
Line 8: 
Line 9: In lvm.resizePV, we need all devices names in the filters parameters.
Line 10: Otherwise the operation will fail. It is needed in case we have more
Line 11: than one LUN on the storage domain.


Line 7: resize-lun: resizePV parameters
Line 8: 
Line 9: In lvm.resizePV, we need all devices names in the filters parameters.
Line 10: Otherwise the operation will fail. It is needed in case we have more
Line 11: than one LUN on the storage domain.
> Please explain lvm needs the other pvs when resizing another pv.
Done
Line 12: 
Line 13: Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899
Line 14: Bug-Url:https://bugzilla.redhat.com/609689


-- 
To view, visit https://gerrit.ovirt.org/42608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4213f82a0307dc91202078b53c0b2c2f24433899
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list