Change in vdsm[master]: Modify _cleanOldFiles method name and avoid naked try-except
danken at redhat.com
danken at redhat.com
Sun Jul 5 15:02:02 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: Modify _cleanOldFiles method name and avoid naked try-except
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/43207/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 551: if fileType in exts and vmId not in self.vmContainer:
Line 552: self.log.debug("cleaning old file " + f)
Line 553: utils.rmFile(constants.P_VDSM_RUN + f)
Line 554: except ValueError:
Line 555: # If file is missing type extention - ignore it
moving the except clause to right after split() would make it more precise, and render the comment redundant.
but frankly, there are no extensions besides .recovery since ovirt-3.0. No need to look for other extensions.
Line 556: pass
Line 557:
Line 558: def dispatchLibvirtEvents(self, conn, dom, *args):
Line 559: try:
--
To view, visit https://gerrit.ovirt.org/43207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5c1053e268abb03c71935a4414a193a1ed40e9f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list