Change in vdsm[master]: iscsicred: Support per-host iscsi credentials database

amureini at redhat.com amureini at redhat.com
Sun Jul 5 07:03:03 UTC 2015


Allon Mureinik has posted comments on this change.

Change subject: iscsicred: Support per-host iscsi credentials database
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/43179/1/vdsm/storage/iscsicred.py
File vdsm/storage/iscsicred.py:

Line 52:     Called from supervdsm since credfiles are root-readonly files.
Line 53:     """
Line 54:     filename = os.path.join(DIR, target_name)
Line 55:     try:
Line 56:         with open(filename, "rb") as f:
Why "rb"? Isn't this a plain text file?
Line 57:             return f.read()
Line 58:     except IOError as e:
Line 59:         if e.errno != errno.ENOENT:
Line 60:             raise


-- 
To view, visit https://gerrit.ovirt.org/43179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6a838f6b8e132d6b0c1a8135f2c28ef1e7f847
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list