Change in vdsm[master]: multipath: Replace timing code with utils.stopwatch

nsoffer at redhat.com nsoffer at redhat.com
Fri Jul 3 17:37:51 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: multipath: Replace timing code with utils.stopwatch
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/42566/3/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 129:     Raises Error if multipathd failed to resize the map.
Line 130:     """
Line 131:     log.debug("Resizing map %r", name)
Line 132:     cmd = [_MULTIPATHD.cmd, "resize", "map", name]
Line 133:     with utils.stopwatch("Resized map %r" % name):
> Why you prefer not to pass the log argument here?
No reason, I'll update to use this module log
Line 134:         rc, out, err = utils.execCmd(cmd, raw=True, execCmdLogger=log)
Line 135:         # multipathd reports some errors using non-zero exit code and stderr
Line 136:         # (need to be root), but the command may return 0, and the result is
Line 137:         # reported using stdout.


-- 
To view, visit https://gerrit.ovirt.org/42566
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ae9c4f7b9e10ef07f1c9a8e8bce9aaf042d9af
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list