Change in vdsm[ovirt-3.5]: net tests: unbreak f20 pep8

sbonazzo at redhat.com sbonazzo at redhat.com
Fri Jul 3 13:20:29 UTC 2015


Sandro Bonazzola has posted comments on this change.

Change subject: net tests: unbreak f20 pep8
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/43190/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 929:             # Try to add additional VLANed bridged network, should succeed
Line 930:             netNameVlanBridged = NETWORK_NAME + '-5'
Line 931:             d['vlan'], d['bridged'] = '200', True
Line 932:             status, msg = self.setupNetworks(
Line 933:                 {netNameVlanBridged: d}, {}, NOCHK)
> Thought: ) could be on next line
I like Martin's idea
Line 934:             self.assertEqual(status, SUCCESS, msg)
Line 935: 
Line 936:             self.assertNetworkDoesntExist(netNameBridgeless)
Line 937:             self.assertNetworkDoesntExist(netNameBridged)


-- 
To view, visit https://gerrit.ovirt.org/43190
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie428df7f34800eca4327a956770e3d1e6c513c9a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list