Change in vdsm[master]: virt: Handle disconnects only if endpoints match
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Fri Jul 3 09:26:23 UTC 2015
Michal Skrivanek has posted comments on this change.
Change subject: virt: Handle disconnects only if endpoints match
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/43141/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 588: srcPath, devAlias, action, reason = args[:-1]
Line 589: v._onIOError(devAlias, reason, action)
Line 590: elif eventid == libvirt.VIR_DOMAIN_EVENT_ID_GRAPHICS:
Line 591: phase, localAddr, remoteAddr, authScheme, subject = args[:-1]
Line 592: v.log.debug('graphics event phase '
please enrich the log with 'service' as well
Line 593: '%s localAddr %s remoteAddr %s'
Line 594: 'authScheme %s subject %s',
Line 595: phase, localAddr, remoteAddr, authScheme, subject)
Line 596: if phase == libvirt.VIR_DOMAIN_EVENT_GRAPHICS_INITIALIZE:
https://gerrit.ovirt.org/#/c/43141/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 351: self._vcpuLimit = None
Line 352: self._vcpuTuneInfo = {}
Line 353: self._numaInfo = {}
Line 354: self._vmJobs = None
Line 355: self._clientPort = ''
> We only need to know about one, I wouldn't know why we want to record all.
on vnc it works via hook and we have a proper rfe. How much more complicated it would be? (it's not too important)
Line 356:
Line 357: def _get_lastStatus(self):
Line 358: # note that we don't use _statusLock here. One of the reasons is the
Line 359: # non-obvious recursive locking in the following flow:
--
To view, visit https://gerrit.ovirt.org/43141
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb3441407aa6e7bc31d37304bce0076e12bb1a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list