Change in vdsm[master]: Removing support in sysv and upstart

danken at redhat.com danken at redhat.com
Fri Jul 3 08:44:14 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Removing support in sysv and upstart
......................................................................


Patch Set 13: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/40726/13/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 545:     def _cleanOldFiles(self):
Line 546:         for f in os.listdir(constants.P_VDSM_RUN):
Line 547:             try:
Line 548:                 vmId, fileType = f.split(".", 1)
Line 549:                 exts = ["guest.socket", "monitor.socket",
I believe that ALL extensions, save of "recovery", are long gone and unused. In a follow-up patch, please re-write _cleanOldFiles as _clean_recovery_files, avoiding the horrible except-pass.
Line 550:                         "stdio.dump", "recovery"]
Line 551:                 if fileType in exts and vmId not in self.vmContainer:
Line 552:                     self.log.debug("removing old file " + f)
Line 553:                     utils.rmFile(constants.P_VDSM_RUN + f)


-- 
To view, visit https://gerrit.ovirt.org/40726
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9af14b3d78badc5250042508d25f294dc514a2d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list