Change in vdsm[master]: iscsicred: Protect sensitive return value in supervdsm log

nsoffer at redhat.com nsoffer at redhat.com
Thu Jul 2 23:21:01 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: iscsicred: Protect sensitive return value in supervdsm log
......................................................................

iscsicred: Protect sensitive return value in supervdsm log

SuperVdsm logs all calls and return values, possibly exposive sensitive
data in its log file.

This patch allows Supervdsm methods to wrap the return value with
ProtectedPassword object, so the results are logged as ********.

Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/43178/1

diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 2a1a8f0..36c67b1 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -53,6 +53,7 @@
 except ImportError:
     _glusterEnabled = False
 
+from vdsm import password
 from vdsm import utils
 from vdsm import sysctl
 from vdsm.tool import restore_nets
@@ -112,6 +113,8 @@
             raise
         callbackLogger.debug('return %s with %s',
                              func.__name__, res)
+        if isinstance(res, password.ProtectedPassword):
+            res = res.value
         return res
     return wrapper
 


-- 
To view, visit https://gerrit.ovirt.org/43178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcfa4ee17466f75270909587c45ee9f703e5e9f3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list