Change in vdsm[master]: snapshot: Add Vm.freeze() and Vm.thaw() methods

fromani at redhat.com fromani at redhat.com
Thu Jul 2 16:11:33 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
......................................................................


Patch Set 7: Code-Review+1

(4 comments)

looks OK. Few minor comments inside for further improvements. I don't mind if you want to address them i separate patches.

https://gerrit.ovirt.org/#/c/43018/7/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 245: 
Line 246:     @recorded
Line 247:     def fsFreeze(self, mountpoints=None, flags=0):
Line 248:         self._failIfRequested()
Line 249:         return 3
please add a comment (or perhaps better a constant) reminding us that this is the number of FS freezed
Line 250: 
Line 251:     @recorded
Line 252:     def fsThaw(self, mountpoints=None, flags=0):
Line 253:         self._failIfRequested()


Line 250: 
Line 251:     @recorded
Line 252:     def fsThaw(self, mountpoints=None, flags=0):
Line 253:         self._failIfRequested()
Line 254:         return 3
same
Line 255: 
Line 256: 
Line 257: class GuestAgent(object):
Line 258:     def __init__(self):


https://gerrit.ovirt.org/#/c/43018/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2890:             else:
Line 2891:                 name = "freezeErr"
Line 2892:             return response.error(name, message=e.get_error_message())
Line 2893: 
Line 2894:         self.log.info("%d guest filesystems frozen", frozen)
Usually I'd have skipped, but we have recently begun a journey to reduce our logging, so:
why is this interesting? if it is important, we should probably report back it to Engine as well. If it is just debug, maybe better to use debug()
Line 2895:         return response.success()
Line 2896: 
Line 2897:     def thaw(self):
Line 2898:         """


Line 2913:             else:
Line 2914:                 name = "thawErr"
Line 2915:             return response.error(name, message=e.get_error_message())
Line 2916: 
Line 2917:         self.log.info("%d guest filesystems thawed", thawed)
same comment as above
Line 2918:         return response.success()
Line 2919: 
Line 2920:     def snapshot(self, snapDrives, memoryParams):
Line 2921:         """Live snapshot command"""


-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list