Change in vdsm[master]: api: 'device' property for RNG device

smelamud at redhat.com smelamud at redhat.com
Thu Jul 2 14:24:39 UTC 2015


Hello Shmuel Melamud,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/43166

to review the following change.

Change subject: api: 'device' property for RNG device
......................................................................

api: 'device' property for RNG device

Added 'device' property for RNG devices as VDSM relies on presence of
this property.

Change-Id: Ic1b5b8a9c908b1d3588a32fbd3e2197fe4926bfa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1233825
Signed-off-by: Shmuel Melamud <smelamud at redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 16 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/43166/1

diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index b16657d..6f2cf0a 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -3406,6 +3406,18 @@
           'specParams': 'VmSmartcardDeviceSpecParams'}}
 
 ##
+# @VmRngDeviceType:
+#
+# An enumeration of VM rng device types
+#
+# @virtio:  supported by qemu and virtio-rng kernel module
+#
+# Since: 4.18.0
+##
+{'enum': 'VmRngDeviceType',
+ 'data': ['virtio']}
+
+##
 # @VmRngDeviceModel:
 #
 # An enumeration of VM rng device models
@@ -3457,6 +3469,8 @@
 #
 # @deviceType:  The device type (always @rng)
 #
+# @device:      The the type of rng device
+#
 # @model:       The model of rng device
 #
 # @specParams:  Additional device parameters
@@ -3464,8 +3478,8 @@
 # Since: 4.14.0
 ##
 {'type': 'VmRngDevice',
- 'data': {'deviceType': 'VmDeviceType', 'model': 'VmRngDeviceModel',
-          'specParams': 'VmRngDeviceSpecParams'}}
+ 'data': {'deviceType': 'VmDeviceType', 'device': 'VmRngDeviceType',
+          'model': 'VmRngDeviceModel', 'specParams': 'VmRngDeviceSpecParams'}}
 
 
 ##


-- 
To view, visit https://gerrit.ovirt.org/43166
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1b5b8a9c908b1d3588a32fbd3e2197fe4926bfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Shmuel Melamud <smelamud at redhat.com>


More information about the vdsm-patches mailing list