Change in vdsm[master]: snapshot: Start the snapshot module

fromani at redhat.com fromani at redhat.com
Thu Jul 2 11:52:22 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: snapshot: Start the snapshot module
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/43018/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: snapshot: Start the snapshot module
Line 8: 
Line 9: This module will hold the code taking a vm snapshot. Currently it
Line 10: include only the GuestAgent class, responsible for freezing and thawing
> There is no name class since each name is defined in different namespace, b
Renaming GuestAgent to OvirtGuestAgent is a correct change, but since our code works only with exactly one GA (OvirtGuestAgent), and this will be true for the foreseeable future, the change looks also a bit pointless (= very low priority).

As for the name here, I'd go with GuestFilesystems, to conform with libvirt terminology as much as we can. Moreover, how libvirt actually implements the APIs should not be (too much) of our concern, so let's not leak details ourselves :)
Line 11: guest file systems during a snapshot.
Line 12: 
Line 13: Freezing or thawing filesystems can fail because of many reasons;
Line 14: libvirt driver does not support freezing, guest agent is not installed


-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list