Change in vdsm[master]: snapshot: Start the snapshot module

fromani at redhat.com fromani at redhat.com
Thu Jul 2 10:56:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: snapshot: Start the snapshot module
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/43018/6/vdsm/virt/snapshot.py
File vdsm/virt/snapshot.py:

Line 51:         """
Line 52:         self._log.info("Freezing guest filesystems")
Line 53: 
Line 54:         try:
Line 55:             frozen = self._dom.fsFreeze()
It took me a while to realize, and now I have to ask.

Libvirt here is just passing the buck to the GA, which, in the case of qemu-ga, will do the dirty work using ioctl(FIFREEZE) inside the VM.

So, how's gonna work with our GA (ovirt-guest-agent)?
There is work on our GA I'm not aware of to support the same functionality?

Ditto for fsThaw below
Line 56:         except libvirt.libvirtError as e:
Line 57:             self._log.warning("Unable to freeze guest filesystems: %s", e)
Line 58:             code = e.get_error_code()
Line 59:             if code == libvirt.VIR_ERR_AGENT_UNRESPONSIVE:


-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list