Change in vdsm[master]: tests: restore default timeout value

nsoffer at redhat.com nsoffer at redhat.com
Thu Jul 2 10:27:34 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: restore default timeout value
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42918/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:

Line 40:     JsonRpcInternalError, \
Line 41:     JsonRpcRequest
Line 42: 
Line 43: 
Line 44: CALL_TIMEOUT = 15
> The tests includes network communication between components. I am not sure 
Please mark this test as @slowtest instead of changing the timeout. Tests run on CI should not depend on timing.
Line 45: CALL_ID = '2c8134fd-7dd4-4cfc-b7f8-6b7549399cb6'
Line 46: 
Line 47: 
Line 48: class _DummyBridge(object):


-- 
To view, visit https://gerrit.ovirt.org/42918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list