Change in vdsm[master]: snapshot: Start the snapshot module

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Jul 2 10:10:05 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: snapshot: Start the snapshot module
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

I wonder why even create a new class at all. Why is it not part of vm.py?
It can very well replace the current snapshot function as we can drive freeze and thaw ourselves for non-ceph volumes too (this is what libvirt does internally anyway, so the additional time/delay shoud be negligent)

https://gerrit.ovirt.org/#/c/43018/6/tests/vmfakelib.py
File tests/vmfakelib.py:

Line 244:         return self._downtimes
Line 245: 
Line 246:     @recorded
Line 247:     def fsFreeze(self, mountpoints=None, flags=0):
Line 248:         self._failIfRequested()
why not silently succeed? that makes more sense in context of fake vdsm
Line 249:         return 3
Line 250: 
Line 251:     @recorded
Line 252:     def fsThaw(self, mountpoints=None, flags=0):


-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list