Change in vdsm[master]: virt: Handle disconnects only if endpoints match

fromani at redhat.com fromani at redhat.com
Thu Jul 2 10:07:46 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Handle disconnects only if endpoints match
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

should be OK, but please look at questions inside

https://gerrit.ovirt.org/#/c/43141/1//COMMIT_MSG
Commit Message:

Line 26: This patch addresses the above mentioned issue by performing a comparison
Line 27: of the remote endpoint that disconnected and remembering only initiated
Line 28: endpoints. In case that multiple connections are established, like in case
Line 29: of spice, the last initiated channel would be remembered and when that one
Line 30: disconnects, it will cause the disconnect handling to proceed.
Question: what happens if disconnections happens in random order?
A connects and logins succesfully
B ditto
C ditto

then

B disconnects
Line 31: 
Line 32: Due to some bug in the handling of graphic events in libvirt, SPICE
Line 33: connections currently do not include the port. A fix for this has been
Line 34: posted upstream and should eventually become available. Therefore, the


https://gerrit.ovirt.org/#/c/43141/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 351:         self._vcpuLimit = None
Line 352:         self._vcpuTuneInfo = {}
Line 353:         self._numaInfo = {}
Line 354:         self._vmJobs = None
Line 355:         self._clientPort = ''
do we want to record all the connections in the future?
Line 356: 
Line 357:     def _get_lastStatus(self):
Line 358:         # note that we don't use _statusLock here. One of the reasons is the
Line 359:         # non-obvious recursive locking in the following flow:


-- 
To view, visit https://gerrit.ovirt.org/43141
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idfb3441407aa6e7bc31d37304bce0076e12bb1a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list