Change in vdsm[master]: tests: restore default timeout value

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Jul 2 07:14:06 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: tests: restore default timeout value
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/42918/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:

Line 40:     JsonRpcInternalError, \
Line 41:     JsonRpcRequest
Line 42: 
Line 43: 
Line 44: CALL_TIMEOUT = 15
> If we need 15 seconds to complete a unit test, the test is severely broken,
The tests includes network communication between components. I am not sure if you checked but in takes 10+ mins for vdsm build to finish. The code is run very slowly and 3 sec is not enough. It has nothing to do how the test is written.

As in title I am restoring the value that was previously used. As you noticed the connection timeouts during the build. By having this value we had no tests which failed due to timeout.

We can pick any timeout value which in principal will be as accurate as 15 secs.
Line 45: CALL_ID = '2c8134fd-7dd4-4cfc-b7f8-6b7549399cb6'
Line 46: 
Line 47: 
Line 48: class _DummyBridge(object):


-- 
To view, visit https://gerrit.ovirt.org/42918
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9edf74e5a06f8ceb8e64000dcaea9dee8247bae
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list