Change in vdsm[master]: snapshot: Start the snapshot module

nsoffer at redhat.com nsoffer at redhat.com
Wed Jul 1 19:57:42 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: snapshot: Start the snapshot module
......................................................................


Patch Set 6:

Michal, we considered adding only freeze api, and doing thaw in VM.snapshot(). We abandoned this direction since it does not allow engine to handle failure cases.

Engine must invoke VM.thaw() if it tried to invoke VM.freeze(), even if it did not get a reply from vdsm. Vdsm cannot be responsible for this when it does not have control over the flow.

-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list