Change in vdsm[master]: hostdev: add test for SR-IOV VF

ibarkan at redhat.com ibarkan at redhat.com
Wed Jul 1 13:13:41 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hostdev: add test for SR-IOV VF
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/43094/1/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 409: 
Line 410:     def testCreateSRIOVVF(self):
Line 411:         dev_spec = {'type': 'hostdev', 'device': _SRIOV_VF,
Line 412:                     'specParams':
Line 413:                     {'macAddr': 'ff:ff:ff:ff:ff:ff', 'vlanId': 3}}
can you please add 'bootOrder': '9' to dev_spec and test that _DEVICE_XML[_SRIOV_VF] has a <boot order="9"/> child for the <interface ..> node?
Line 414:         device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)


Line 410:     def testCreateSRIOVVF(self):
Line 411:         dev_spec = {'type': 'hostdev', 'device': _SRIOV_VF,
Line 412:                     'specParams':
Line 413:                     {'macAddr': 'ff:ff:ff:ff:ff:ff', 'vlanId': 3}}
Line 414:         device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
nit:
--this does not explicitly realated to this patch, but for unittesting hostdev in general.

during get_device_params
 -> get_device_ref_and_params
  -> parse_device_params
   _sriov_totalvfs is called, and fails with an IOError. This is luckily swallwen, but it will be nice to monkeypathch in this test. Currently this leads to HostDevice._deviceParams['total_vfs'] to be missing.


-- 
To view, visit https://gerrit.ovirt.org/43094
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf2e07f492508757be2691417c706219ded54af
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list