Change in vdsm[master]: virt: Forcibly unregister fds with errors from epoll

danken at redhat.com danken at redhat.com
Wed Jul 1 11:36:33 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: Forcibly unregister fds with errors from epoll
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/42570/4/vdsm/virt/vmchannels.py
File vdsm/virt/vmchannels.py:

Line 60:                 # Try to forcibly remove this FD from EPOLL
Line 61:                 # To really stop receiving events
Line 62:                 try:
Line 63:                     self._epoll.unregister(fileno)
Line 64:                 except IOError:
> Actually, this should not happen, since we just got that event, and this is
another thread may close the fd since the event was fired.

but if that has happened, the FD might have also been re-used and and re-registered to this epoll, and this unregister call might kill an unrelated fd.

I don't like this at all.
Line 65:                     pass
Line 66:         elif (event & select.EPOLLIN):
Line 67:             obj = self._channels.get(fileno, None)
Line 68:             if obj:


-- 
To view, visit https://gerrit.ovirt.org/42570
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a452f7837267434bc836fced4c2efd92d745cf
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer%redhat.com at gtempaccount.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list