Change in vdsm[master]: snapshot: Start the snapshot module

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Jul 1 08:30:14 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: snapshot: Start the snapshot module
......................................................................


Patch Set 3: Code-Review-1

this is currently done within the VM's code for taking snapshot (via libvirt flag). If this is going to be a more serious refactoring then it doesn't seem to me as a good idea to do that right now since we're approaching 3.6 GA

why not simply extend the VM's API with one line before and one line after the snapshot?

-- 
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e4c54f461039de99823c3b80a10be0a960c4273
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list