Change in vdsm[master]: asyncore: dynamic tick support
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Tue Jan 27 10:50:56 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: dynamic tick support
......................................................................
Patch Set 4:
(1 comment)
Please add a test for this change.
http://gerrit.ovirt.org/#/c/37057/4/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 444: def _outgoing_heartbeat_expiration_interval(self):
Line 445: since_last_update = (elapsed_time() - self._lastOutgoingTimeStamp)
Line 446: return(self._outgoingHeartBeat / 1000.0) - since_last_update
Line 447:
Line 448: def next_check_interval(self, dispatcher):
Why do we pass dispatcher here? It is not used in this method.
Line 449: if self._outgoingHeartBeat == 0:
Line 450: return None
Line 451:
Line 452: return max(self._outgoing_heartbeat_expiration_interval, 0)
--
To view, visit http://gerrit.ovirt.org/37057
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list