Change in vdsm[master]: asyncore: Move generic reactor functionality
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Tue Jan 27 10:44:47 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: asyncore: Move generic reactor functionality
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/37055/4/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:
Line 355: self._map = {}
Line 356: self._isRunning = False
Line 357: self._wakeupEvent = AsyncoreEvent(self._map)
Line 358:
Line 359: def add_dispatcher(self, disp):
Was that intentional to add 2 new methods in this patch (add_dispatcher and remove_dispatcher)? From patch description I only see that we wanted to move generic reactor code here.
Line 360: disp.add_channel(self._map)
Line 361:
Line 362: def remove_dispatcher(self, disp):
Line 363: disp.del_channel(self._map)
--
To view, visit http://gerrit.ovirt.org/37055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list