Change in vdsm[master]: gluster: Added gluster snapshot restore verb.

barumuga at redhat.com barumuga at redhat.com
Sat Jan 31 00:38:44 UTC 2015


Bala.FA has posted comments on this change.

Change subject: gluster: Added gluster snapshot restore verb.
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/34638/7/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:

Line 1118:         'snapRestore/snapshot/name').text
Line 1119:     snapshotRestore['snapshotUuid'] = tree.find(
Line 1120:         'snapRestore/snapshot/uuid').text
Line 1121: 
Line 1122:     return {'snapRestoreDetail': snapshotRestore}
I think you can return snapRestore dict.  Check with other verbs how this is done.
Line 1123: 
Line 1124: 
Line 1125: @makePublic
Line 1126: def snapshotRestore(snapName):


-- 
To view, visit http://gerrit.ovirt.org/34638
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I422fab5bc9ec9dc51d759bad46487c60051bbfc1
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list