Change in vdsm[master]: gluster: add createBrick verb

tjeyasin at redhat.com tjeyasin at redhat.com
Fri Jan 30 17:43:59 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/35498/9/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 104:         content.append(
Line 105:             "UUID=%s\t%s\t%s\t%s\t%s\t%s\n" % (_getUuidByDevice(device),
Line 106:                                                mountPoint, fsType,
Line 107:                                                mntOpts, fsDump, fsPass))
Line 108:         safeWrite(self.fileName, content)
> add() is doing too many things here.  This function should do only add like
Done
Line 109: 
Line 110: 
Line 111: def _parseDevices(devices):
Line 112:     deviceList = []


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list