Change in vdsm[master]: executor: introduce the executor library

fromani at redhat.com fromani at redhat.com
Thu Jan 29 17:11:09 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: executor: introduce the executor library
......................................................................


Patch Set 33:

(1 comment)

http://gerrit.ovirt.org/#/c/29191/33/lib/vdsm/executor.py
File lib/vdsm/executor.py:

Line 186:         finally:
Line 187:             # there is a race here: even in presence of succesfull
Line 188:             # execution, discard can fire just before we disarm it.
Line 189:             # We know and we don't care about sporadic replacements
Line 190:             # of well-behaving workers.
> There is no race here - we discard workers that were too slow to disarm the
Right, and your wording make it clear.
Will change the comment accordingly.
Line 191:             if discard is not None:
Line 192:                 discard.cancel()
Line 193:             if self._discarded:
Line 194:                 raise _WorkerDiscarded()


-- 
To view, visit http://gerrit.ovirt.org/29191
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06da1ba57868dc2c7db67a1868ad10087a1cff2
Gerrit-PatchSet: 33
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list