Change in vdsm[master]: lvm: Fail loudly if called with unexpected input

nsoffer at redhat.com nsoffer at redhat.com
Thu Jan 29 08:40:14 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lvm: Fail loudly if called with unexpected input
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37329/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 724:                 else:
Line 725:                     raise
Line 726: 
Line 727:     # We must be very carefull here; any value execpt True or False is a user
Line 728:     # error.
> If this comes from the xml/json rpc API it should be validated there. Inter
I agree that we should not validate types in general, but in rare places we *require* certain types, we must validate them.
Line 729:     if type(force) != bool:
Line 730:         raise ValueError("Invalid value for 'force': %r" % force)
Line 731: 
Line 732:     if force is True:


-- 
To view, visit http://gerrit.ovirt.org/37329
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If9e6754d4aa2efaf894a9309cfaa4595d710063b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list