Change in vdsm[master]: virt: cleaner getAllVmStats

danken at redhat.com danken at redhat.com
Tue Jan 27 16:40:50 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: cleaner getAllVmStats
......................................................................


virt: cleaner getAllVmStats

the api.Global.getAllVmStats method was implemented reusing
api.Global.getVMList and api.VM.getStats().

This lead to unnecessary work, and a lot of layering traversal
with objects being wrapped in responses, which in turn are
promptly discarded and rewrapped again to obtain the final
result. All of this without any clear benefit.

This patch drops all the layering and use simple and lean
methods to obtain the same result doing much less work.
Unfortunately, total performance gains are expected
to be negligible because this function was already
very low in the profiling data.

Related-To: https://bugzilla.redhat.com/1177634
Change-Id: If1ed3f49c236086c6184973762d9909d7f79bf7e
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35140
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/API.py
M vdsm/clientIF.py
M vdsm/virt/vm.py
3 files changed, 5 insertions(+), 7 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/35140
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1ed3f49c236086c6184973762d9909d7f79bf7e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list