Change in vdsm[master]: zombiereaper: Raise if used incorrectly

danken at redhat.com danken at redhat.com
Tue Jan 27 10:25:05 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: zombiereaper: Raise if used incorrectly
......................................................................


zombiereaper: Raise if used incorrectly

zombiereaper was trying to reap pid when it was not initialized
properly. This lead to slient failures and and leaking zombies processes
for the process lifetime.

In commit 0636b8607b (Revert "supervdsm: Add zombiereaper to supervdsm")
we removed zombiereaper from supervdsm, but there are still callers that
assume it is inizialized. This patch ensures callers will fail loudly if
zombiereaper was not initialzied.

The tests are more carefull now not change the Python process state when
importing tests from the test module.

Change-Id: Ib3a275a3f022c7b686ce07693b7c0b147762b043
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/37260
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M lib/vdsm/infra/zombiereaper/__init__.py
M lib/vdsm/infra/zombiereaper/tests.py
2 files changed, 19 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3a275a3f022c7b686ce07693b7c0b147762b043
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list