Change in vdsm[master]: vm: Fix extend size calculation

fromani at redhat.com fromani at redhat.com
Mon Jan 26 12:44:56 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: Fix extend size calculation
......................................................................


Patch Set 1:

(4 comments)

a few initial comments

http://gerrit.ovirt.org/#/c/37274/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1411: 
Line 1412:         # FIXME: mergeCandidates should be a dictionary of candidate volumes
Line 1413:         # once libvirt starts reporting watermark information for all volumes.
Line 1414:         mergeCandidates = {}
Line 1415: 
unrelated change - even though I like it :)
Line 1416:         for drive in self._devices[hwclass.DISK]:
Line 1417:             if not drive.supportsExtension():
Line 1418:                 continue
Line 1419: 


Line 1443:         # physical from the replica itself. See
Line 1444:         # https://www.redhat.com/archives/libvir-list/2014-December/
Line 1445:         # msg00762.html
Line 1446:         if not drive.blockDev:
Line 1447:             replica = drive.diskReplicate
For completeness' sake, same remark as parent patch: how can we make sure this is valid?
I'm fine talking about this in parent patch (not yet read comments ATM).
Line 1448:             res = self.cif.irs.getVolumeSize(
Line 1449:                 replica["domainID"], replica["poolID"], replica["imageID"],
Line 1450:                 replica["volumeID"])
Line 1451:             if res['status']['code'] != 0:


Line 1446:         if not drive.blockDev:
Line 1447:             replica = drive.diskReplicate
Line 1448:             res = self.cif.irs.getVolumeSize(
Line 1449:                 replica["domainID"], replica["poolID"], replica["imageID"],
Line 1450:                 replica["volumeID"])
for my understanding, how costly is this call?
I don't have any problem with that, as IIRC this is the blessed way to gather that info. Just trying to broad my knowledge.
Line 1451:             if res['status']['code'] != 0:
Line 1452:                 raise VolumeInfoError("Error getting volume info %s" %
Line 1453:                                       replica["volumeID"])
Line 1454:             physical = int(res['apparentsize'])


Line 3558:         elif srcDrive.format:
Line 3559:             driverAttrs['type'] = 'raw'
Line 3560: 
Line 3561:         if (srcDrive.propagateErrors == 'on' or
Line 3562:                 utils.tobool(srcDrive.propagateErrors)):
unrelated change
Line 3563:             driverAttrs['error_policy'] = 'enospace'
Line 3564:         else:
Line 3565:             driverAttrs['error_policy'] = 'stop'
Line 3566: 


-- 
To view, visit http://gerrit.ovirt.org/37274
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7afe3a7f6cfbb47eb76249d3851b7adaf4dbba6f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list