Change in vdsm[master]: Live Merge: Update drive.format after active layer merge

fromani at redhat.com fromani at redhat.com
Mon Jan 26 09:19:20 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Live Merge: Update drive.format after active layer merge
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36923/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4971:                                          drive.imageID, volumeID)
Line 4972:         if res['status']['code'] != 0:
Line 4973:             self.log.error("Unable to get info of volume %s (domain: %s image:"
Line 4974:                            " %s)", volumeID, drive.domainID, drive.imageID)
Line 4975:             raise RuntimeError("Unable to get volume info")
Does it make any sense to have a more specific exception here?
Line 4976:         driveFormat = res['info']['format'].lower()
Line 4977: 
Line 4978:         # Sync this VM's data strctures.  Ugh, we're storing the same info in
Line 4979:         # two places so we need to change it twice.


-- 
To view, visit http://gerrit.ovirt.org/36923
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list