Change in vdsm[master]: supervdsm: use os.path instead of string concatenation

nsoffer at redhat.com nsoffer at redhat.com
Sat Jan 24 00:34:17 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: supervdsm: use os.path instead of string concatenation
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37226/2/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 75: from storage.devicemapper import _removeMapping, _getPathsStatus
Line 76: from vdsm.config import config
Line 77: import mkimage
Line 78: 
Line 79: _UDEV_RULE_FILE_DIR = os.path.abspath('/etc/udev/rules.d/')
This is not required and not related to your patch. The only change needed is to remove the trailing "/".
Line 80: _UDEV_RULE_FILE_PREFIX = '99-vdsm-'
Line 81: _UDEV_RULE_FILE_EXT = '.rules'
Line 82: _UDEV_RULE_FILE_NAME = os.path.join(
Line 83:     _UDEV_RULE_FILE_DIR, _UDEV_RULE_FILE_PREFIX + '%s-%s' +


-- 
To view, visit http://gerrit.ovirt.org/37226
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80b69743a7a0765947ba0cf3aaaa00b4b05b7d2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list