Change in vdsm[master]: utils: NoIntr* references moved from misc to utils

osvoboda at redhat.com osvoboda at redhat.com
Fri Jan 23 12:39:43 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: utils: NoIntr* references moved from misc to utils
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Nice, but please move the sorting of imports to a patch of (on?) its own (and please consider using a case-insensitive sort). You don't have to reverify but please keep it clean.

http://gerrit.ovirt.org/#/c/36795/4/tests/utilsTests.py
File tests/utilsTests.py:

Line 32: from multiprocessing import Process
Line 33: from testValidation import checkSudo
Line 34: from testValidation import stresstest
Line 35: from testlib import VdsmTestCase as TestCaseBase
Line 36: from testlib import permutations, expandPermutations
Although I understand that vim's :sort cares about the letter case, I would prefer "natural", case-independent sort.

And more importantly, please split the unrelated work with imports (which I nonetheless appreciate) to a simple patch on which you base your work.
Line 37: from vdsm import constants
Line 38: from vdsm import utils
Line 39: from vmTestsData import VM_STATUS_DUMP
Line 40: import copy


-- 
To view, visit http://gerrit.ovirt.org/36795
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I96cefb794029fe46c7e7ada816001a4d1026ea52
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list