Change in vdsm[master]: netlink: replace ipwrapper monitor

danken at redhat.com danken at redhat.com
Fri Jan 23 10:55:21 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netlink: replace ipwrapper monitor
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/37239/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 190: @contextmanager
Line 191: def nonChangingOperstate(device):
Line 192:     """Raises an exception if it detects that the device link state changes."""
Line 193:     originalState = operstate(device).lower()
Line 194:     mon = monitor.Monitor(groups=('link',))
the context manager can be pretty here, too.
Line 195:     mon.start()
Line 196:     try:
Line 197:         yield
Line 198:     finally:


-- 
To view, visit http://gerrit.ovirt.org/37239
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2ee7d16c79eea7c8ed1f0780aafbaa00356978
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list