Change in vdsm[master]: netlink: replace ipwrapper monitor
danken at redhat.com
danken at redhat.com
Fri Jan 23 09:37:11 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: replace ipwrapper monitor
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/37239/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 175:
Line 176:
Line 177: def _waitForKnownOperstate(device, timeout=1):
Line 178: mon = monitor.Monitor(groups=('link',), timeout=timeout)
Line 179: mon.start()
this code begs to make the monitor a context manager:
with monitor.Monitor(groups=('link',), timeout=timeout) as mon:
taking care of start and stop. (better in another patch)
Line 180: try:
Line 181: state = operstate(device).lower()
Line 182: if state == 'unknown':
Line 183: for event in mon:
http://gerrit.ovirt.org/#/c/37239/2/tests/ipwrapperTests.py
File tests/ipwrapperTests.py:
Line 202
Line 203
Line 204
Line 205
Line 206
why do you drop this class?
--
To view, visit http://gerrit.ovirt.org/37239
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2ee7d16c79eea7c8ed1f0780aafbaa00356978
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list