Change in vdsm[master]: Live Merge: Retry sync on recoverable errors

alitke at redhat.com alitke at redhat.com
Thu Jan 22 19:25:45 UTC 2015


Adam Litke has posted comments on this change.

Change subject: Live Merge: Retry sync on recoverable errors
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/36922/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4943: 
Line 4944:         if not isVdsmImage(drive):
Line 4945:             self.log.debug("Skipping drive '%s' which is not a vdsm image",
Line 4946:                            drive.name)
Line 4947:             raise ValueError("Drive is not a vdsm image")
> If drive is not a vdsm image (has pool id, domain id, image id and volume i
You're right, it can't.  I guess this shouldn't be needed then.
Line 4948: 
Line 4949:         curVols = [x['volumeID'] for x in drive.volumeChain]
Line 4950:         chains = self._driveGetActualVolumeChain([drive])
Line 4951:         try:


Line 4952:             chain = chains[drive['alias']]
Line 4953:         except KeyError:
Line 4954:             self.log.debug("Unable to determine volume chain. Skipping volume "
Line 4955:                            "chain synchronization for drive %s", drive.name)
Line 4956:             raise
> Can you explain how a drive can have no chain? Is this expected if storage 
Only if libvirt stops reporting the chain to us.  I don't see this happening unless someone downgrades libvirt on the host in the middle of a live merge.  I guess we can drop this too.
Line 4957: 
Line 4958:         volumes = [entry.uuid for entry in chain]
Line 4959:         activePath = chain[-1].path
Line 4960:         self.log.debug("vdsm chain: %s, libvirt chain: %s", curVols, volumes)


-- 
To view, visit http://gerrit.ovirt.org/36922
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I731d316074ac50eb60795a7eb4175738c1310b4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list