Change in vdsm[master]: vm: properly implement readPauseCode

fromani at redhat.com fromani at redhat.com
Thu Jan 22 14:28:05 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: properly implement readPauseCode
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/37118/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2979:             for device, error in diskErrors.iteritems():
Line 2980:                 if error == libvirt.VIR_DOMAIN_DISK_ERROR_NO_SPACE:
Line 2981:                     self.log.warning('device %s out of space', device)
Line 2982:                     return 'ENOSPC'
Line 2983:                 elif error != libvirt.VIR_DOMAIN_DISK_ERROR_NONE:
> Thanks for reporting EIO on top of ENOSPC, but I'm afraid my comment was no
Will change to EOTHER.

To provide context and not excuse, here it follows the reason why I picked EIO:

This is what libvirt can report: http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDiskErrorCode

it boils down to
- all good
- no space
- unspecified I/O error

so 'unspecified I/O error' felt best mapped on EIO than on EOTHER - it is still a I/O error after all.
However I didn't take into account the existing behaviour of VDSM (too narrow vision), so will change.
Line 2984:                     self.log.warning('device %s reported error %d',
Line 2985:                                      device, error)
Line 2986:                     return 'EIO'
Line 2987: 


-- 
To view, visit http://gerrit.ovirt.org/37118
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2f200e2856669bb7dbcc904898f326b939b1ddd
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list