Change in vdsm[master]: gluster: volume snapshot list and snapshot list verbs.
barumuga at redhat.com
barumuga at redhat.com
Thu Jan 22 13:34:32 UTC 2015
Bala.FA has posted comments on this change.
Change subject: gluster: volume snapshot list and snapshot list verbs.
......................................................................
Patch Set 10: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/36087/10//COMMIT_MSG
Commit Message:
Line 26: 'volCount': number volume involved in this snapshot}...
Line 27: }
Line 28: }
Line 29:
Line 30: *glusterVolumeSnapshotList: gives the list of all the snapshots
It should be one verb glusterVolumeSnapshotsList to do both
glusterVolumeSnapshotsList(volumeName=None)
gives all snapshots of all volumes when volumeName is given, it gives snapshots of given volume.
Please check how glusterVolumesList is done.
Output dict would be like
{'v1': {'snapshots': [{'snapshotName': 'snap1_v1',
'snapshotUuid': '8add41ae-c60c-4023-a1a6-5093a5d35603',
'createTime': '2014-10-27 16:25:03',
'snapVolume': '5eeaf23def3f446d898e1de8461a6aa7'
'snapVolumeStatus': 'ACTIVATED'}, ...],
'snapRemaining': 252},
'v2': {'snapshots': [{'snapshotName': 'snap1_v2',
'snapshotUuid': '8add41ae-c60c-4023-a1a6-1233a5d35603',
'createTime': '2014-10-27 16:25:03',
'snapVolume': '5eeaf23def3f446d898e1123461a6aa7'
'snapVolumeStatus': 'DEACTIVATED'}, ...],
'snapRemaining': 252}, ...}
Sorry for the confusion
Line 31: present in a volume. It take volume name as argument.
Line 32: Returns:
Line 33: {'snapshots': {'snapName':{
Line 34: 'createTime': time of snap creation,
http://gerrit.ovirt.org/#/c/36087/10/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1213: raise ge.GlusterXmlErrorInfoException(err=[etree.tostring(xmltree)])
Line 1214:
Line 1215:
Line 1216: @makePublic
Line 1217: def volumeSnapshotList(volumeName):
Please align with gluster cli here and have correct verb name in api.py
Line 1218: command = _getGlusterSnapshotCmd() + ["info", "volume", volumeName]
Line 1219:
Line 1220: try:
Line 1221: xmltree = _execGlusterXml(command)
--
To view, visit http://gerrit.ovirt.org/36087
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06945d6781432b7fb40e417dd21c0ecf107de132
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list